Add/update newsletter messages in translation file#18982
Closed
arnoudhgz wants to merge 1 commit intomagento:2.2-developfrom
Closed
Add/update newsletter messages in translation file#18982arnoudhgz wants to merge 1 commit intomagento:2.2-developfrom
arnoudhgz wants to merge 1 commit intomagento:2.2-developfrom
Conversation
magento-engcom-team
added
Partner: MediaCT
Contributor
|
Hi @arnoudhgz. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Contributor
Author
|
@orlangur I was unable to remove the merge commit messages in my fork, so I forked again. The issue is also still active on the 2.3-develop branch. |
Contributor
|
@arnoudhgz please prepare PR against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR: #18932 (was closed by me because of out-of-sync fork)
Description (*)
The messages in the Newsletter module were update, but the messages in the translation files have been forgotten.
When using translation tools it is mandatory to have correct strings in the i18n files. This pull request aims to solve this.
Manual testing scenarios (*)
Compare the messages in app/code/Magento/Newsletter/Controller/Manage/Save.php with the i18n file
Contribution checklist (*)